]> Cypherpunks repositories - gostls13.git/commit
runtime: remove arbitrary 5-second timeout in TestNeedmDeadlock
authorCherry Mui <cherryyz@google.com>
Fri, 27 Jun 2025 23:45:22 +0000 (19:45 -0400)
committerCherry Mui <cherryyz@google.com>
Sat, 28 Jun 2025 01:17:14 +0000 (18:17 -0700)
commitb51f1cdb8752c2fdd6a2bf06224aab0b5c07caac
treec5c54c562b2e26f09c7a2f59f2e7729cffaed914
parentf1e6ae2f6f5424f9f5c6dc915866d4f457c1483e
runtime: remove arbitrary 5-second timeout in TestNeedmDeadlock

The NeedmDeadlock test program currently has a 5-second timeout,
which is sort of arbitrary. It is long enough in regular mode
(which usually takes 0.0X seconds), but not quite so for
configurations like ASAN. Instead of using an arbitrary timeout,
just use the test's deadline. The test program is invoked with
testenv.Command, which will send it a SIGQUIT before the deadline
expires.

Fixes #56420 (at least for the asan builder).

Change-Id: I0b13651cb07241401837ca2e60eaa1b83275b093
Reviewed-on: https://go-review.googlesource.com/c/go/+/684697
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
src/runtime/testdata/testprogcgo/needmdeadlock.go