]> Cypherpunks repositories - gostls13.git/commit
database/sql: check for nil connRequest.conn before use
authorDaniel Theophanes <kardianos@gmail.com>
Sun, 25 Mar 2018 23:58:27 +0000 (16:58 -0700)
committerDaniel Theophanes <kardianos@gmail.com>
Thu, 10 May 2018 19:41:08 +0000 (19:41 +0000)
commitb98ffdf859f0fec2acb1765bf5b62ce1e4587c2b
treeab292c776d26aff4698d727d4ec1c0267b4cebc7
parentb9c8e870d14775a02c6e87ca0344f623f7cab5f0
database/sql: check for nil connRequest.conn before use

The connRequest may return a nil conn value. However in a rare
case that is difficult to test for it was being passed to
DB.putConn without a nil check. This was an error as this
made no sense if the driverConn is nil. This also caused
a panic in putConn.

A test for this would be nice, but didn't find a sane
way to test for this condition.

Fixes #24445

Change-Id: I827316e856788a5a3ced913f129bb5869b7bcf68
Reviewed-on: https://go-review.googlesource.com/102477
Run-TryBot: Daniel Theophanes <kardianos@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
src/database/sql/sql.go