]> Cypherpunks repositories - gostls13.git/commit
crypto/rand: properly handle large Read on windows
authorRoland Shoemaker <roland@golang.org>
Tue, 26 Apr 2022 02:02:35 +0000 (19:02 -0700)
committerRoland Shoemaker <roland@golang.org>
Thu, 5 May 2022 22:44:02 +0000 (22:44 +0000)
commitbb1f4416180511231de6d17a1f2f55c82aafc863
treed7adc9404c0ccab25c7f3683e5dbe045400522c8
parent7c74b0db8a27188d0ca3bb2f4bd46d00c0dc8eea
crypto/rand: properly handle large Read on windows

Use the batched reader to chunk large Read calls on windows to a max of
1 << 31 - 1 bytes. This prevents an infinite loop when trying to read
more than 1 << 32 -1 bytes, due to how RtlGenRandom works.

This change moves the batched function from rand_unix.go to rand.go,
since it is now needed for both windows and unix implementations.

Fixes #52561

Change-Id: Id98fc4b1427e5cb2132762a445b2aed646a37473
Reviewed-on: https://go-review.googlesource.com/c/go/+/402257
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Filippo Valsorda <valsorda@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
src/crypto/rand/rand.go
src/crypto/rand/rand_batched_test.go
src/crypto/rand/rand_unix.go
src/crypto/rand/rand_windows.go