]> Cypherpunks repositories - gostls13.git/commit
[dev.typeparams] cmd/compile: small fixes for stenciling
authorDan Scales <danscales@google.com>
Wed, 10 Feb 2021 23:26:40 +0000 (15:26 -0800)
committerDan Scales <danscales@google.com>
Thu, 11 Feb 2021 21:46:39 +0000 (21:46 +0000)
commitc0aa7bd7602257dd7d5be4db13dd10284bd5f826
tree4bbf440d7233815eb6697d6f4f80241f28099069
parentdf23540ddef33f47faf7bba2a6fc37c44a662ab0
[dev.typeparams] cmd/compile: small fixes for stenciling

 - Create the stencil name using targ.Type.String(), which handles cases
   where, for example, a type argument is a pointer to a named type,
   etc. *obj.

 - Set name.Def properly for a new stenciled func (have the symbol point
   back to the associated function node).  Will be required when exporting.

 - Add missing copying of Func field when making copies of Name nodes.
   (On purpose (it seems), Name nodes don't have a copy() function, so
   we have to copy all the needed fields explicitly.)

 - Deal with nil type in subster.node(), which is the type of the return
   value for a function that doesn't return anything.

 - Fix min to match standard want/go form, and add in float tests.  Changed
   Got -> got in bunch of other typeparam tests.

 - Add new tests index.go, settable.go, and smallest.go (similar to
   examples in the type param proposal), some of which need the above
   changes.

Change-Id: I09a72302bc1fd3635a326da92405222afa222e85
Reviewed-on: https://go-review.googlesource.com/c/go/+/291109
Trust: Dan Scales <danscales@google.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
src/cmd/compile/internal/noder/stencil.go
test/typeparam/index.go [new file with mode: 0644]
test/typeparam/map.go
test/typeparam/min.go
test/typeparam/settable.go [new file with mode: 0644]
test/typeparam/smallest.go [new file with mode: 0644]
test/typeparam/stringer.go
test/typeparam/sum.go