]> Cypherpunks repositories - gostls13.git/commit
src/make.*: make --no-clean flag a no-op that prints a warning
authorMatthew Dempsky <mdempsky@google.com>
Wed, 11 Aug 2021 19:40:12 +0000 (12:40 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Wed, 11 Aug 2021 22:07:50 +0000 (22:07 +0000)
commitdea23e9ca80dd629041cba03ae2544dad19948ee
tree45de39c742356c2223134c0c80b3ec1e69f0c2b1
parentd4c0ed26ace91cb21fc0a67f088648674052aa3d
src/make.*: make --no-clean flag a no-op that prints a warning

This flag is undocumented and is no longer useful. Users who want to
install additional toolchains without cleaning the installed packages
should just use `go install`.

This CL changes cmd/dist to print a warning that --no-clean is
deprecated and to advise users to use `go install std cmd` instead,
and then otherwise ignores it:

```
$ ./make.bash --no-clean
Building Go cmd/dist using $GOROOT_BOOTSTRAP. (devel +b7a85e0003 linux/amd64)
warning: --no-clean is deprecated and has no effect; use 'go install std cmd' instead
Building Go toolchain1 using $GOROOT_BOOTSTRAP.
```

Fixes #47204.

Change-Id: I275031832098401a49e491e324e8de3427973630
Reviewed-on: https://go-review.googlesource.com/c/go/+/341392
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
src/cmd/dist/build.go
src/make.bash
src/make.bat
src/make.rc