]> Cypherpunks repositories - gostls13.git/commit
net: use network and host as singleflight key during lookupIP
authorCezar Sa Espinola <cezarsa@gmail.com>
Thu, 7 Mar 2019 15:52:16 +0000 (12:52 -0300)
committerIan Lance Taylor <iant@golang.org>
Fri, 8 Mar 2019 01:21:52 +0000 (01:21 +0000)
commite341bae08d75611adea6566c1d01c1e3a0de57f9
treea6b016e81daed4743fd1953b90a2641f694d3f41
parent6a9da69147a3b32e48f8dfea8c82f5975af9cc62
net: use network and host as singleflight key during lookupIP

In CL 120215 the cgo resolver was changed to have different logic based
on the network being queried. However, the singleflight cache key wasn't
updated to also include the network. This way it was possible for
concurrent queries to return the result for the wrong network.

This CL changes the key to include both network and host, fixing the
problem.

Fixes #30521

Change-Id: I8b41b0ce1d9a02d18876c43e347654312eba22fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/166037
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
src/net/lookup.go
src/net/lookup_test.go