From 00045b76e50d98db354aa185bcbd60a6f62499ac Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 23 Nov 2021 10:39:07 -0500 Subject: [PATCH] runtime: skip TestCgoCallbackGC on darwin-amd64-10_14 builder This test occasionally fails due to a real bug on this platform. Due to the age of the platform and the rarity of the failure, we do not believe that the bug is worth working around. Fixes #43926 Change-Id: Ia227c5afe81fc21b6630813228f976cc3a54013c Reviewed-on: https://go-review.googlesource.com/c/go/+/366537 Trust: Bryan C. Mills Run-TryBot: Bryan C. Mills Reviewed-by: Cherry Mui TryBot-Result: Go Bot --- src/runtime/crash_cgo_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 9a174fa549..45ee6d6905 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -64,6 +64,10 @@ func TestCgoCallbackGC(t *testing.T) { t.Skip("too slow for mips64x builders") } } + if testenv.Builder() == "darwin-amd64-10_14" { + // TODO(#23011): When the 10.14 builders are gone, remove this skip. + t.Skip("skipping due to platform bug on macOS 10.14; see https://golang.org/issue/43926") + } got := runTestProg(t, "testprogcgo", "CgoCallbackGC") want := "OK\n" if got != want { -- 2.50.0