From 0163b3b32cad2ed3331e2b197c68387f12246cd8 Mon Sep 17 00:00:00 2001 From: cui fliter Date: Sun, 20 Aug 2023 18:33:50 +0800 Subject: [PATCH] all: remove redundant string conversions when formatting []byte with %s Change-Id: I603051a3174b139ffb81d20d42979c7f3f04a09a Reviewed-on: https://go-review.googlesource.com/c/go/+/521136 Run-TryBot: Filippo Valsorda Auto-Submit: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Reviewed-by: Bryan Mills Run-TryBot: shuang cui Reviewed-by: Filippo Valsorda TryBot-Result: Gopher Robot --- src/bytes/example_test.go | 6 +++--- src/crypto/rsa/example_test.go | 4 ++-- src/runtime/testdata/testprogcgo/numgoroutine.go | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/bytes/example_test.go b/src/bytes/example_test.go index 41a5e2e5bf..20faf3e1f5 100644 --- a/src/bytes/example_test.go +++ b/src/bytes/example_test.go @@ -81,9 +81,9 @@ func ExampleBuffer_Next() { var b bytes.Buffer b.Grow(64) b.Write([]byte("abcde")) - fmt.Printf("%s\n", string(b.Next(2))) - fmt.Printf("%s\n", string(b.Next(2))) - fmt.Printf("%s", string(b.Next(2))) + fmt.Printf("%s\n", b.Next(2)) + fmt.Printf("%s\n", b.Next(2)) + fmt.Printf("%s", b.Next(2)) // Output: // ab // cd diff --git a/src/crypto/rsa/example_test.go b/src/crypto/rsa/example_test.go index d07ee7d18b..d176743f2f 100644 --- a/src/crypto/rsa/example_test.go +++ b/src/crypto/rsa/example_test.go @@ -78,7 +78,7 @@ func ExampleDecryptPKCS1v15SessionKey() { return } - fmt.Printf("Plaintext: %s\n", string(plaintext)) + fmt.Printf("Plaintext: %s\n", plaintext) } func ExampleSignPKCS1v15() { @@ -149,7 +149,7 @@ func ExampleDecryptOAEP() { return } - fmt.Printf("Plaintext: %s\n", string(plaintext)) + fmt.Printf("Plaintext: %s\n", plaintext) // Remember that encryption only provides confidentiality. The // ciphertext should be signed before authenticity is assumed and, even diff --git a/src/runtime/testdata/testprogcgo/numgoroutine.go b/src/runtime/testdata/testprogcgo/numgoroutine.go index 1b9f202f46..9cbb4e4b0d 100644 --- a/src/runtime/testdata/testprogcgo/numgoroutine.go +++ b/src/runtime/testdata/testprogcgo/numgoroutine.go @@ -70,7 +70,7 @@ func checkNumGoroutine(label string, want int) (string, bool) { sbuf = sbuf[:runtime.Stack(sbuf, true)] n = strings.Count(string(sbuf), "goroutine ") if n != want { - fmt.Printf("%s Stack: want %d; got %d:\n%s\n", label, want, n, string(sbuf)) + fmt.Printf("%s Stack: want %d; got %d:\n%s\n", label, want, n, sbuf) return "", false } return string(sbuf), true -- 2.50.0