From 02f445258c284f295d8648078d6cc15836670756 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 25 Aug 2020 15:19:50 +0200 Subject: [PATCH] cmd/link: remove superfluous check in TestIssue34788Android386TLSSequence err != nil is already checked in the if condition one line above. Change-Id: If36cdb41016f7be98a65be0a7211d85cd6017f87 Reviewed-on: https://go-review.googlesource.com/c/go/+/250477 Run-TryBot: Tobias Klauser TryBot-Result: Gobot Gobot Reviewed-by: Cherry Zhang --- src/cmd/link/link_test.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go index 3b5efdf7a3..72ff01c932 100644 --- a/src/cmd/link/link_test.go +++ b/src/cmd/link/link_test.go @@ -455,9 +455,7 @@ func TestIssue34788Android386TLSSequence(t *testing.T) { cmd := exec.Command(testenv.GoToolPath(t), "tool", "compile", "-o", obj, src) cmd.Env = append(os.Environ(), "GOARCH=386", "GOOS=android") if out, err := cmd.CombinedOutput(); err != nil { - if err != nil { - t.Fatalf("failed to compile blah.go: %v, output: %s\n", err, out) - } + t.Fatalf("failed to compile blah.go: %v, output: %s\n", err, out) } // Run objdump on the resulting object. -- 2.48.1