From 04e2e81ecbb6a34863cb46f22d7b8f434c8b852f Mon Sep 17 00:00:00 2001 From: Patrik Lundin Date: Thu, 4 Jul 2019 22:48:23 +0000 Subject: [PATCH] net/http: stop ExampleServer_Shutdown from hanging on error Running the example code when not having permissions to bind to port 80 will cause the program to hang after printing the error message. Change-Id: I2433ba2629b362fc8f1731e40cab5eea72ec354f GitHub-Last-Rev: 0bb3dc08b6f646470fc6ff208ea12bca901a2299 GitHub-Pull-Request: golang/go#32947 Reviewed-on: https://go-review.googlesource.com/c/go/+/185157 Reviewed-by: Emmanuel Odeke Run-TryBot: Emmanuel Odeke TryBot-Result: Gobot Gobot --- src/net/http/example_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/http/example_test.go b/src/net/http/example_test.go index 2a09f5f6c6..a783b46618 100644 --- a/src/net/http/example_test.go +++ b/src/net/http/example_test.go @@ -132,7 +132,7 @@ func ExampleServer_Shutdown() { if err := srv.ListenAndServe(); err != http.ErrServerClosed { // Error starting or closing listener: - log.Printf("HTTP server ListenAndServe: %v", err) + log.Fatalf("HTTP server ListenAndServe: %v", err) } <-idleConnsClosed -- 2.50.0