From 04eb35998a3a999c830969f802744ab9274714a8 Mon Sep 17 00:00:00 2001 From: hitzhangjie Date: Thu, 25 Aug 2022 09:34:49 +0000 Subject: [PATCH] cmd/trace: display goroutines (PC=0) with clearer description This PR fixes: #54425 #49994 Change-Id: Id60a3ba6930f8e29b12b6d8f80945decd2ce31bc GitHub-Last-Rev: 60a040aa2f111f64f571597799ce7ca317e1d281 GitHub-Pull-Request: golang/go#54575 Reviewed-on: https://go-review.googlesource.com/c/go/+/425042 Reviewed-by: Michael Knyszek Reviewed-by: Michael Pratt --- src/cmd/trace/goroutines.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/cmd/trace/goroutines.go b/src/cmd/trace/goroutines.go index 74d1b0a11d..7850fc0ff1 100644 --- a/src/cmd/trace/goroutines.go +++ b/src/cmd/trace/goroutines.go @@ -64,6 +64,11 @@ func httpGoroutines(w http.ResponseWriter, r *http.Request) { var glist []gtype for k, v := range gss { v.ID = k + // If goroutine didn't run during the trace (no sampled PC), + // the v.ID and v.Name will be zero value. + if v.ID == 0 && v.Name == "" { + v.Name = "(Inactive, no stack trace sampled)" + } glist = append(glist, v) } sort.Slice(glist, func(i, j int) bool { return glist[i].ExecTime > glist[j].ExecTime }) -- 2.50.0