From 04f3cf0faaebe59ae24e15531c27d5d885add20e Mon Sep 17 00:00:00 2001 From: David Symonds Date: Thu, 24 May 2012 13:42:02 +1000 Subject: [PATCH] flag: include flag name in redefinition panic. R=golang-dev, rsc, r CC=golang-dev https://golang.org/cl/6250043 --- src/pkg/flag/flag.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pkg/flag/flag.go b/src/pkg/flag/flag.go index f0842a18a2..5444ad141c 100644 --- a/src/pkg/flag/flag.go +++ b/src/pkg/flag/flag.go @@ -620,8 +620,9 @@ func (f *FlagSet) Var(value Value, name string, usage string) { flag := &Flag{name, usage, value, value.String()} _, alreadythere := f.formal[name] if alreadythere { - fmt.Fprintf(f.out(), "%s flag redefined: %s\n", f.name, name) - panic("flag redefinition") // Happens only if flags are declared with identical names + msg := fmt.Sprintf("%s flag redefined: %s", f.name, name) + fmt.Fprintln(f.out(), msg) + panic(msg) // Happens only if flags are declared with identical names } if f.formal == nil { f.formal = make(map[string]*Flag) -- 2.48.1