From 0907d57abf34e1d11debef2ea7bb4d7b2c11f51e Mon Sep 17 00:00:00 2001 From: Keith Randall Date: Fri, 25 Feb 2022 16:06:53 -0800 Subject: [PATCH] cmd/compile: emit types of constants which are instantiated generic types Normally types of constants are emitted when the type is defined (an ODCLTYPE). However, the types of constants where the type is an instantiated generic type made inside the constant declaration, do not normally get emitted. But the DWARF processor in the linker wants to see those types. So we emit them during stenciling. Fixes #51245 Change-Id: I59f20f1d7b91501c9ac760cf839a354356331fc6 Reviewed-on: https://go-review.googlesource.com/c/go/+/388117 Trust: Keith Randall Run-TryBot: Keith Randall TryBot-Result: Gopher Robot Reviewed-by: Cherry Mui --- src/cmd/compile/internal/gc/obj.go | 4 ++++ test/typeparam/issue51245.go | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 test/typeparam/issue51245.go diff --git a/src/cmd/compile/internal/gc/obj.go b/src/cmd/compile/internal/gc/obj.go index 5353435ed1..74e4c0a890 100644 --- a/src/cmd/compile/internal/gc/obj.go +++ b/src/cmd/compile/internal/gc/obj.go @@ -217,6 +217,10 @@ func dumpGlobalConst(n ir.Node) { if ir.ConstOverflow(v, t) { return } + } else { + // If the type of the constant is an instantiated generic, we need to emit + // that type so the linker knows about it. See issue 51245. + _ = reflectdata.TypeLinksym(t) } base.Ctxt.DwarfIntConst(base.Ctxt.Pkgpath, n.Sym().Name, types.TypeSymName(t), ir.IntVal(t, v)) } diff --git a/test/typeparam/issue51245.go b/test/typeparam/issue51245.go new file mode 100644 index 0000000000..bd4f7c5dc9 --- /dev/null +++ b/test/typeparam/issue51245.go @@ -0,0 +1,16 @@ +// build -gcflags=-G=3 + +// Copyright 2022 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package main + +type T[P any] int +const C T[int] = 3 + +type T2 int +const C2 T2 = 9 + +func main() { +} -- 2.48.1