From 09686a58734382ace059f1dbd882dadbb39b2268 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Mon, 12 Sep 2016 17:08:21 -0700 Subject: [PATCH] cmd/compile: remove another bytes.Buffer use in fmt.go Missed in prior commit. Change-Id: Ib3a41fb4e4d41feeb28c316fe70a329c73e72379 Reviewed-on: https://go-review.googlesource.com/29088 Run-TryBot: Robert Griesemer TryBot-Result: Gobot Gobot Reviewed-by: Matthew Dempsky --- src/cmd/compile/internal/gc/fmt.go | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/cmd/compile/internal/gc/fmt.go b/src/cmd/compile/internal/gc/fmt.go index b430283838..c65c382ae4 100644 --- a/src/cmd/compile/internal/gc/fmt.go +++ b/src/cmd/compile/internal/gc/fmt.go @@ -5,7 +5,6 @@ package gc import ( - "bytes" "cmd/internal/obj" "fmt" "strconv" @@ -739,35 +738,35 @@ func (t *Type) typefmt(flag FmtFlag) string { Yyerror("unknown internal map type") } - var buf bytes.Buffer + buf := make([]byte, 0, 64) if t.IsFuncArgStruct() { - buf.WriteString("(") + buf = append(buf, '(') var flag1 FmtFlag if fmtmode == FTypeId || fmtmode == FErr { // no argument names on function signature, and no "noescape"/"nosplit" tags flag1 = FmtShort } for i, f := range t.Fields().Slice() { if i != 0 { - buf.WriteString(", ") + buf = append(buf, ", "...) } - buf.WriteString(Fldconv(f, flag1)) + buf = append(buf, Fldconv(f, flag1)...) } - buf.WriteString(")") + buf = append(buf, ')') } else { - buf.WriteString("struct {") + buf = append(buf, "struct {"...) for i, f := range t.Fields().Slice() { if i != 0 { - buf.WriteString(";") + buf = append(buf, ';') } - buf.WriteString(" ") - buf.WriteString(Fldconv(f, FmtLong)) + buf = append(buf, ' ') + buf = append(buf, Fldconv(f, FmtLong)...) } if t.NumFields() != 0 { - buf.WriteString(" ") + buf = append(buf, ' ') } - buf.WriteString("}") + buf = append(buf, '}') } - return buf.String() + return string(buf) case TFORW: if t.Sym != nil { -- 2.48.1