From 096e2bffdf065dbaa4e5023d6b83ce694a37b949 Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Mon, 8 May 2017 16:40:49 +1000 Subject: [PATCH] cmd/go: run tests that require symlinks Change-Id: I19a724ea4eb1ba0ff558721650c89a949e53b7c7 Reviewed-on: https://go-review.googlesource.com/42895 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/go/go_test.go | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index 930df005df..bc6e1baab7 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -1908,10 +1908,7 @@ func TestGoTestDashIDashOWritesBinary(t *testing.T) { // Issue 4568. func TestSymlinksList(t *testing.T) { - switch runtime.GOOS { - case "plan9", "windows": - t.Skipf("skipping symlink test on %s", runtime.GOOS) - } + testenv.MustHaveSymlink(t) tg := testgo(t) defer tg.cleanup() @@ -1929,10 +1926,7 @@ func TestSymlinksList(t *testing.T) { // Issue 14054. func TestSymlinksVendor(t *testing.T) { - switch runtime.GOOS { - case "plan9", "windows": - t.Skipf("skipping symlink test on %s", runtime.GOOS) - } + testenv.MustHaveSymlink(t) tg := testgo(t) defer tg.cleanup() @@ -1956,10 +1950,7 @@ func TestSymlinksVendor(t *testing.T) { // Issue 15201. func TestSymlinksVendor15201(t *testing.T) { - switch runtime.GOOS { - case "plan9", "windows": - t.Skipf("skipping symlink test on %s", runtime.GOOS) - } + testenv.MustHaveSymlink(t) tg := testgo(t) defer tg.cleanup() @@ -1976,10 +1967,7 @@ func TestSymlinksVendor15201(t *testing.T) { } func TestSymlinksInternal(t *testing.T) { - switch runtime.GOOS { - case "plan9", "windows": - t.Skipf("skipping symlink test on %s", runtime.GOOS) - } + testenv.MustHaveSymlink(t) tg := testgo(t) defer tg.cleanup() @@ -3995,10 +3983,7 @@ func TestExecutableGOROOT(t *testing.T) { t.Fatalf("%s env GOROOT = %q with pkg/tool, want %q", newGoTool, got, want) } - switch runtime.GOOS { - case "plan9", "windows": - t.Skipf("skipping symlink test on %s", runtime.GOOS) - } + testenv.MustHaveSymlink(t) tg.tempDir("notgoroot/bin") symGoTool := tg.path("notgoroot/bin/go" + exeSuffix) -- 2.50.0