From 09aeb6e33ab426eff4676a3baf694d5a3019e9fc Mon Sep 17 00:00:00 2001 From: Kir Kolyshkin Date: Mon, 1 Jul 2024 12:41:56 -0700 Subject: [PATCH] os: add TODO about removing test exception TestChtimesOmit excludes the failure on DragonFly BSD when both atime and mtime are omitted. The relevant Dragonfly BSD bug is now fixed in git (see [1]). Add a TODO comment to remove the exclusion from the test once the fix is generally available. This comment also addresses the question why the exception exists. Amends CL 591535. [1]: https://github.com/DragonFlyBSD/DragonFlyBSD/commit/c7c71870ed0 Change-Id: I3b53582301d44feb76b53788aa337c380ba82592 Reviewed-on: https://go-review.googlesource.com/c/go/+/595958 Reviewed-by: Ian Lance Taylor Auto-Submit: Ian Lance Taylor LUCI-TryBot-Result: Go LUCI Reviewed-by: Than McIntosh --- src/os/os_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/os/os_test.go b/src/os/os_test.go index 9519aa0fc6..878974384d 100644 --- a/src/os/os_test.go +++ b/src/os/os_test.go @@ -1440,6 +1440,9 @@ func testChtimesOmit(t *testing.T, omitAt, omitMt bool) { gotAtime := Atime(fs) gotMtime := fs.ModTime() + // TODO: remove the dragonfly omitAt && omitMt exceptions below once the + // fix (https://github.com/DragonFlyBSD/DragonFlyBSD/commit/c7c71870ed0) + // is available generally and on CI runners. if !gotAtime.Equal(wantAtime) { errormsg := fmt.Sprintf("atime mismatch, got: %q, want: %q", gotAtime, wantAtime) switch runtime.GOOS { -- 2.48.1