From 09f1f5d76d648f9dcdc86ff814b7e463ecca93df Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Mon, 30 Jul 2012 10:13:54 -0400 Subject: [PATCH] misc/dashboard/codereview: add LastUpdate field to CL To be filled in by a later CL. I deployed a test version to App Engine to work on setting the values, so there are a few records that have this field set already. That field is breaking the live version, so I have pushed a new copy with this 1-line change to the live version I assumed that appengine/datastore was like every other marshaling and unmarshaling package we have in Go (for example, encoding/gob, encoding/json, encoding/xml, and protobuf) and that if it loaded an unknown field it would just ignore it. Apparently not. Sorry. R=dsymonds TBR=dsymonds CC=golang-dev https://golang.org/cl/6454064 --- misc/dashboard/codereview/dashboard/cl.go | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go index 181d2e40fe..c9cee24527 100644 --- a/misc/dashboard/codereview/dashboard/cl.go +++ b/misc/dashboard/codereview/dashboard/cl.go @@ -49,6 +49,7 @@ type CL struct { FirstLine string `datastore:",noindex"` LGTMs []string NotLGTMs []string + LastUpdate string // Mail information. Subject string `datastore:",noindex"` -- 2.48.1