From 0bde2cf5fe1fea62bb0975a7098c55abd8f3da34 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 11 Feb 2022 11:32:11 -0500 Subject: [PATCH] runtime: skip TestSegv/SegvInCgo failures with "runtime: unknown pc" This test has failed on four different builders in the past month. Moreover, because every Go program depends on "runtime", it is likely to be run any time a user runs 'go test all' in their own program. Since the test is known to be flaky, let's skip it to avoid introducing testing noise until someone has time to investigate. It seems like we have enough samples in the builder logs to at least start with. For #50979 Change-Id: I9748a82fbb97d4ed95d6f474427e5aa6ecdb023d Reviewed-on: https://go-review.googlesource.com/c/go/+/385154 Trust: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Cherry Mui TryBot-Result: Gopher Robot --- src/runtime/crash_cgo_test.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go index 8c250f72d6..c9c9406a15 100644 --- a/src/runtime/crash_cgo_test.go +++ b/src/runtime/crash_cgo_test.go @@ -626,13 +626,11 @@ func TestSegv(t *testing.T) { // a VDSO call via asmcgocall. testenv.SkipFlaky(t, 50504) } - if testenv.Builder() == "linux-mips64le-mengzhuo" && strings.Contains(got, "runtime: unknown pc") { - // Runtime sometimes throw "unknown pc" when generating the traceback. - // Curiously, that doesn't seem to happen on the linux-mips64le-rtrk - // builder. - testenv.SkipFlaky(t, 50605) - } } + if test == "SegvInCgo" && strings.Contains(got, "runtime: unknown pc") { + testenv.SkipFlaky(t, 50979) + } + nowant := "runtime: " if strings.Contains(got, nowant) { t.Errorf("unexpectedly saw %q in output", nowant) -- 2.50.0