From 10d1d5b6736e8806899ac6b80e56b340e17dd17d Mon Sep 17 00:00:00 2001 From: Emmanuel Odeke Date: Tue, 8 Dec 2015 02:01:03 -0700 Subject: [PATCH] net/http: testStreamingGet now in http2 mode Change-Id: I9a1fe057f5bf008fa16577a7d71064050aea47e9 Reviewed-on: https://go-review.googlesource.com/17525 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/net/http/client_test.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index e59ab2cd0e..09c71b7602 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -493,20 +493,23 @@ func (j *RecordingJar) logf(format string, args ...interface{}) { fmt.Fprintf(&j.log, format, args...) } -func TestStreamingGet(t *testing.T) { +func TestStreamingGet_h1(t *testing.T) { testStreamingGet(t, false) } +func TestStreamingGet_h2(t *testing.T) { testStreamingGet(t, true) } + +func testStreamingGet(t *testing.T, h2 bool) { defer afterTest(t) say := make(chan string) - ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) { + cst := newClientServerTest(t, h2, HandlerFunc(func(w ResponseWriter, r *Request) { w.(Flusher).Flush() for str := range say { w.Write([]byte(str)) w.(Flusher).Flush() } })) - defer ts.Close() + defer cst.close() - c := &Client{} - res, err := c.Get(ts.URL) + c := cst.c + res, err := c.Get(cst.ts.URL) if err != nil { t.Fatal(err) } -- 2.50.0