From 111064925b34bfd60949c09f0d0b06c8f34430f2 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Wed, 16 Nov 2016 12:26:23 +0000 Subject: [PATCH] testing: comment out flag.Parse from example The TestMain docs explain that flag.Parse() should be called if TestMain itself depends on command-line flags. The issue here is that the example implementation does not use any flags, and thus the flag.Parse call is unnecessary. This leads to people who use this example as a starting point for their own implementations to forget that the call is not necessary in most cases. Comment it out instead of removing the line to keep it as a reminder, as suggested by Minux Ma. Change-Id: I6ffc5413e7036366ae3cf0f069b7065e832a3b45 Reviewed-on: https://go-review.googlesource.com/33273 Reviewed-by: Minux Ma Reviewed-by: Ian Lance Taylor --- src/testing/testing.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/testing/testing.go b/src/testing/testing.go index 01f5da31d7..f08c5c6b8e 100644 --- a/src/testing/testing.go +++ b/src/testing/testing.go @@ -196,7 +196,7 @@ // A simple implementation of TestMain is: // // func TestMain(m *testing.M) { -// flag.Parse() +// // call flag.Parse() here if TestMain uses flags // os.Exit(m.Run()) // } // -- 2.50.0