From 112c4d569e8881cc9910039bf4c45176a9b1f619 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Mon, 29 Jun 2020 14:20:04 -0400 Subject: [PATCH] cmd/fix: print warning to stderr, show provenance This cgo warning shows up when running "go test" in cmd/fix: warning: no cgo types: exit status 1 (It may show up at other times too.) Warnings belong on standard error, and while we're here, make it say where it came from. Change-Id: I3eaba592a219cc6abf2d584762374f9d6ec5135e Reviewed-on: https://go-review.googlesource.com/c/go/+/240597 Trust: Russ Cox Reviewed-by: Jay Conrod --- src/cmd/fix/typecheck.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/fix/typecheck.go b/src/cmd/fix/typecheck.go index 66e0cdcec0..f45155b06d 100644 --- a/src/cmd/fix/typecheck.go +++ b/src/cmd/fix/typecheck.go @@ -207,7 +207,7 @@ func typecheck(cfg *TypeConfig, f *ast.File) (typeof map[interface{}]string, ass return nil }() if err != nil { - fmt.Printf("warning: no cgo types: %s\n", err) + fmt.Fprintf(os.Stderr, "go fix: warning: no cgo types: %s\n", err) } } -- 2.50.0