From 1207ee896c193fbd629f9d9bf746f69a60e15b96 Mon Sep 17 00:00:00 2001 From: cuiweixie Date: Sun, 4 Sep 2022 20:07:22 +0800 Subject: [PATCH] cmd/doc: use strings.Builder Change-Id: Ib33d1f1c2e9aed0cb9e00bd699c4ae4a2df5dfca Reviewed-on: https://go-review.googlesource.com/c/go/+/428288 Run-TryBot: Rob Pike Reviewed-by: Michael Knyszek Reviewed-by: Rob Pike Auto-Submit: Rob Pike Reviewed-by: Damien Neil TryBot-Result: Gopher Robot --- src/cmd/doc/doc_test.go | 4 ++-- src/cmd/doc/pkg.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cmd/doc/doc_test.go b/src/cmd/doc/doc_test.go index 5887ad3395..6a259ae19e 100644 --- a/src/cmd/doc/doc_test.go +++ b/src/cmd/doc/doc_test.go @@ -1012,7 +1012,7 @@ func TestDotSlashLookup(t *testing.T) { if err := os.Chdir(filepath.Join(buildCtx.GOROOT, "src", "text")); err != nil { t.Fatal(err) } - var b bytes.Buffer + var b strings.Builder var flagSet flag.FlagSet err = do(&b, &flagSet, []string{"./template"}) if err != nil { @@ -1030,7 +1030,7 @@ func TestDotSlashLookup(t *testing.T) { // when there should be no output at all. Issue 37969. func TestNoPackageClauseWhenNoMatch(t *testing.T) { maybeSkip(t) - var b bytes.Buffer + var b strings.Builder var flagSet flag.FlagSet err := do(&b, &flagSet, []string{"template.ZZZ"}) // Expect an error. diff --git a/src/cmd/doc/pkg.go b/src/cmd/doc/pkg.go index 35f2eb24bf..4cebdc957a 100644 --- a/src/cmd/doc/pkg.go +++ b/src/cmd/doc/pkg.go @@ -420,7 +420,7 @@ func (pkg *Package) oneLineNodeDepth(node ast.Node, depth int) string { default: // As a fallback, use default formatter for all unknown node types. - buf := new(bytes.Buffer) + buf := new(strings.Builder) format.Node(buf, pkg.fs, node) s := buf.String() if strings.Contains(s, "\n") { -- 2.51.0