From 131d7e0d0ee4471dc97f24d223aeef47ba6809d5 Mon Sep 17 00:00:00 2001 From: Paul Jolly Date: Fri, 11 May 2018 15:02:45 +0100 Subject: [PATCH] cmd/go: set DepOnly on package when calling go list -deps Currently .DepOnly is set when go list -test is invoked to help distinguish those packages that matched the command line spec from those which are dependencies (of test packages). This is also useful when calling go list -deps for the same reason. Change-Id: Ifc0e68dad0fd01355928793ef803691dee5f4f29 Reviewed-on: https://go-review.googlesource.com/112755 Run-TryBot: Paul Jolly TryBot-Result: Gobot Gobot Reviewed-by: Bryan C. Mills Reviewed-by: Russ Cox --- src/cmd/go/go_test.go | 4 ++++ src/cmd/go/internal/list/list.go | 1 + 2 files changed, 5 insertions(+) diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index a44866f6b2..abe23ff52d 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -1975,6 +1975,10 @@ func TestGoListTest(t *testing.T) { tg.run("list", "-test", "runtime/cgo") tg.grepStdout(`^runtime/cgo$`, "missing runtime/cgo") + + tg.run("list", "-deps", "-f", "{{if .DepOnly}}{{.ImportPath}}{{end}}", "sort") + tg.grepStdout(`^reflect$`, "missing reflect") + tg.grepStdoutNot(`^sort`, "unexpected sort") } func TestGoListCgo(t *testing.T) { diff --git a/src/cmd/go/internal/list/list.go b/src/cmd/go/internal/list/list.go index 7261d24839..d519dcc5e0 100644 --- a/src/cmd/go/internal/list/list.go +++ b/src/cmd/go/internal/list/list.go @@ -335,6 +335,7 @@ func runList(cmd *base.Command, args []string) { // Show vendor-expanded paths in listing p.TestImports = p.Resolve(p.TestImports) p.XTestImports = p.Resolve(p.XTestImports) + p.DepOnly = !cmdline[p] } if *listTest { -- 2.50.0