From 15c62e8535125f096c2425330fe9b561c38e7ee4 Mon Sep 17 00:00:00 2001 From: Sameer Ajmani Date: Mon, 13 Feb 2017 14:40:48 -0500 Subject: [PATCH] net/http: document Response.Header values that are subordinate to other fields I noticed that Content-Length may appear in http.Response.Header, but the docs say it should be omitted. Per discussion with bradfitz@, updating the docs to indicate that the struct fields are authoritative. Change-Id: Id1807ff9d4ba5de425d8b147205f29b18351230f Reviewed-on: https://go-review.googlesource.com/36842 Reviewed-by: Brad Fitzpatrick --- src/net/http/response.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/net/http/response.go b/src/net/http/response.go index ae118fb386..1b19088a72 100644 --- a/src/net/http/response.go +++ b/src/net/http/response.go @@ -37,9 +37,10 @@ type Response struct { // Header maps header keys to values. If the response had multiple // headers with the same key, they may be concatenated, with comma // delimiters. (Section 4.2 of RFC 2616 requires that multiple headers - // be semantically equivalent to a comma-delimited sequence.) Values - // duplicated by other fields in this struct (e.g., ContentLength) are - // omitted from Header. + // be semantically equivalent to a comma-delimited sequence.) When + // Header values are duplicated by other fields in this struct (e.g., + // ContentLength, TransferEncoding, Trailer), the field values are + // authoritative. // // Keys in the map are canonicalized (see CanonicalHeaderKey). Header Header -- 2.50.0