From 1698018955a712608476892798c992b99aad101a Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 23 Oct 2015 13:59:08 -0400 Subject: [PATCH] runtime: note a minor issue with GODEUG=gcstoptheworld Change-Id: I91cda8d88b0852cd0f868d33c594206bcca0c386 Reviewed-on: https://go-review.googlesource.com/16352 Reviewed-by: Rick Hudson --- src/runtime/mgc.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/mgc.go b/src/runtime/mgc.go index 88cee5b8f6..235c1aac5d 100644 --- a/src/runtime/mgc.go +++ b/src/runtime/mgc.go @@ -916,6 +916,9 @@ func startGC(mode gcMode, forceTrigger bool) { releasem(mp) mp = nil + // TODO: In gcstoptheworld debug mode, multiple goroutines may + // detect the heap trigger simultaneously and then start + // multiple STW GCs, which will run sequentially. if debug.gcstoptheworld == 1 { mode = gcForceMode } else if debug.gcstoptheworld == 2 { -- 2.48.1