From 16a72125d53b31e2f70a6922bc398dcbba354b7a Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Fri, 17 Aug 2018 15:53:35 -0400 Subject: [PATCH] cmd/go/internal/modfetch: correct TestCodeRepo expectation The proxy protocol was simplified to only send (and only receive) the Path and Version fields in the JSON blob, not Name and Short. (Those make sense when querying a VCS repo directly, but not when talking about extracted modules.) So don't expect them in the test. Fixes #27042. Change-Id: I3daacd668126e2227dcc8e6b89ee0cf0e3c8497c Reviewed-on: https://go-review.googlesource.com/129684 Run-TryBot: Russ Cox TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/go/internal/modfetch/coderepo_test.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/cmd/go/internal/modfetch/coderepo_test.go b/src/cmd/go/internal/modfetch/coderepo_test.go index c46705105d..79b82786cb 100644 --- a/src/cmd/go/internal/modfetch/coderepo_test.go +++ b/src/cmd/go/internal/modfetch/coderepo_test.go @@ -228,10 +228,9 @@ var codeRepoTests = []struct { path: "swtch.com/testmod", rev: "v1.0.0", version: "v1.0.0", - name: "v1.0.0", - short: "v1.0.0", - time: time.Date(1972, 7, 18, 12, 34, 56, 0, time.UTC), - gomod: "module \"swtch.com/testmod\"\n", + // NO name or short - we intentionally ignore those in the proxy protocol + time: time.Date(1972, 7, 18, 12, 34, 56, 0, time.UTC), + gomod: "module \"swtch.com/testmod\"\n", }, { // redirect to googlesource -- 2.50.0