From 17eee31020b982c10a2bf21f446743137968240b Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Wed, 17 Aug 2016 15:56:29 -0700 Subject: [PATCH] go/types: enable disabled test for comma-ok expressions This was fixed long ago but the test was not enabled. For #8189. Change-Id: Ia44ef752b6bf076f3e243d2d0db326a392a20193 Reviewed-on: https://go-review.googlesource.com/27310 Run-TryBot: Robert Griesemer TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/go/types/api_test.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/go/types/api_test.go b/src/go/types/api_test.go index 60e55de634..1084de3164 100644 --- a/src/go/types/api_test.go +++ b/src/go/types/api_test.go @@ -171,13 +171,11 @@ func TestTypesInfo(t *testing.T) { `x.(int)`, `(int, bool)`, }, - // TODO(gri): uncomment if we accept issue 8189. - // {`package p2; type mybool bool; var m map[string]complex128; var b mybool; func _() { _, b = m["foo"] }`, - // `m["foo"]`, - // `(complex128, p2.mybool)`, - // }, - // TODO(gri): remove if we accept issue 8189. - {`package p2; var m map[string]complex128; var b bool; func _() { _, b = m["foo"] }`, + {`package p2a; type mybool bool; var m map[string]complex128; var b mybool; func _() { _, b = m["foo"] }`, + `m["foo"]`, + `(complex128, p2a.mybool)`, + }, + {`package p2b; var m map[string]complex128; var b bool; func _() { _, b = m["foo"] }`, `m["foo"]`, `(complex128, bool)`, }, -- 2.48.1