From 19f5c233d1355d98feef37d704eb76ac75886d49 Mon Sep 17 00:00:00 2001 From: LE Manh Cuong Date: Thu, 2 May 2019 15:48:14 +0700 Subject: [PATCH] cmd/compile: remove outdate TODO in inl.go Mid-stack inlining is enable now, see #19348, but we still can not remove the special case for runtime.heapBits.nextArena, because runtime.heapBits.next is too complex to be inlined (cost 96 exceeds budget 80). Change-Id: I04ea86509074afdc83a3f70d68b8a1a8829763d1 Reviewed-on: https://go-review.googlesource.com/c/go/+/174839 Reviewed-by: Brad Fitzpatrick --- src/cmd/compile/internal/gc/inl.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/cmd/compile/internal/gc/inl.go b/src/cmd/compile/internal/gc/inl.go index 5013c55663..addba98e3e 100644 --- a/src/cmd/compile/internal/gc/inl.go +++ b/src/cmd/compile/internal/gc/inl.go @@ -343,10 +343,6 @@ func (v *hairyVisitor) visit(n *Node) bool { // runtime.heapBits.next even though // it calls slow-path // runtime.heapBits.nextArena. - // - // TODO(austin): Once mid-stack - // inlining is the default, remove - // this special case. break } } -- 2.48.1