From 1b591dfb1f071d978448966e979e40b1f265c1a5 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 28 Apr 2016 15:16:46 -0500 Subject: [PATCH] os/exec: fix variable shadow, don't leak goroutine Goroutine leak checking is still too tedious, so untested. See #6705 which is my fault for forgetting to mail out. Change-Id: I899fb311c9d4229ff1dbd3f54fe307805e17efee Reviewed-on: https://go-review.googlesource.com/22581 Reviewed-by: Ahmed W. Run-TryBot: Brad Fitzpatrick Reviewed-by: Brad Fitzpatrick --- src/os/exec/exec.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/os/exec/exec.go b/src/os/exec/exec.go index 76fcba90bf..5121b9b2cc 100644 --- a/src/os/exec/exec.go +++ b/src/os/exec/exec.go @@ -412,7 +412,7 @@ func (c *Cmd) WaitContext(ctx context.Context) error { var waitDone chan struct{} if ctx != nil { - waitDone := make(chan struct{}) + waitDone = make(chan struct{}) go func() { select { case <-ctx.Done(): -- 2.50.0