From 1bcfdc777ad38bbb4faec8e1db2eaa92873f4e10 Mon Sep 17 00:00:00 2001 From: David Chase Date: Fri, 4 Nov 2022 11:23:12 -0400 Subject: [PATCH] cmd/compile: change the multiple (gossa)hash separator from ; to / Semicolon has bad copy-paste ergonomics; it requires quoting. Slash is okay, and won't be a separator ever in debug strings because it is already used in e.g. ssa/phase/debug=etc. Change-Id: I493360e9282666eea1a342971a77df2ebd6c92ad Reviewed-on: https://go-review.googlesource.com/c/go/+/447975 Reviewed-by: Keith Randall Run-TryBot: David Chase Reviewed-by: Keith Randall TryBot-Result: Gopher Robot --- src/cmd/compile/internal/base/hashdebug.go | 2 +- src/cmd/compile/internal/base/hashdebug_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/base/hashdebug.go b/src/cmd/compile/internal/base/hashdebug.go index c93d042f71..609f80393e 100644 --- a/src/cmd/compile/internal/base/hashdebug.go +++ b/src/cmd/compile/internal/base/hashdebug.go @@ -140,7 +140,7 @@ func NewHashDebug(ev, s string, file writeSyncer) *HashDebug { hd.no = true return hd } - ss := strings.Split(s, ";") + ss := strings.Split(s, "/") hd.matches = append(hd.matches, toHashAndMask(ss[0], ev)) // hash searches may use additional EVs with 0, 1, 2, ... suffixes. for i := 1; i < len(ss); i++ { diff --git a/src/cmd/compile/internal/base/hashdebug_test.go b/src/cmd/compile/internal/base/hashdebug_test.go index decdf5ce0f..b74169f895 100644 --- a/src/cmd/compile/internal/base/hashdebug_test.go +++ b/src/cmd/compile/internal/base/hashdebug_test.go @@ -130,7 +130,7 @@ func TestHashNoMatch(t *testing.T) { func TestHashSecondMatch(t *testing.T) { ws := new(bufferWithSync) - hd := NewHashDebug("GOSSAHASH", "001100;0011", ws) + hd := NewHashDebug("GOSSAHASH", "001100/0011", ws) check := hd.DebugHashMatch("bar") msg := ws.String() -- 2.50.0