From 1c45f98fa38d9600ee1c60c2bfba3c0dced86087 Mon Sep 17 00:00:00 2001 From: Carl Shapiro Date: Fri, 20 Sep 2013 17:27:56 -0700 Subject: [PATCH] test/chan: avoid wrap-around in memstats comparison The select2.go test assumed that the memory allocated between its two samplings of runtime.ReadMemStats is strictly increasing. To avoid failing the tests when this is not true, a greater-than check is introduced before computing the difference in allocated memory. R=golang-dev, r, cshapiro CC=golang-dev https://golang.org/cl/13701046 --- test/chan/select2.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/chan/select2.go b/test/chan/select2.go index 4a08139126..ccf9dab81b 100644 --- a/test/chan/select2.go +++ b/test/chan/select2.go @@ -47,7 +47,8 @@ func main() { runtime.GC() runtime.ReadMemStats(memstats) - if memstats.Alloc-alloc > 1.1e5 { + // Be careful to avoid wraparound. + if memstats.Alloc > alloc && memstats.Alloc-alloc > 1.1e5 { println("BUG: too much memory for 100,000 selects:", memstats.Alloc-alloc) } } -- 2.50.0