From 1cf6d4748c9b4b7be38d6cdf0a1e419b33c306ac Mon Sep 17 00:00:00 2001 From: Wei Xiao Date: Thu, 13 Apr 2017 14:06:43 +0800 Subject: [PATCH] cmd/dist: fix incorrect platform string shared by all tests all tests currently share the same platform string and fail to vet expected platforms Fixes #19958 Change-Id: I2801e1e84958e31975769581e27ea5ca6a0edf5b Reviewed-on: https://go-review.googlesource.com/40511 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/dist/test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 9ba7798069..9aa966d14c 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -340,7 +340,8 @@ var stdOutErrAreTerminals func() bool func (t *tester) registerTests() { if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-vetall") { // Run vet over std and cmd and call it quits. - for osarch := range cgoEnabled { + for k := range cgoEnabled { + osarch := k t.tests = append(t.tests, distTest{ name: "vet/" + osarch, heading: "go vet std cmd", -- 2.50.0