From 1d083eba5bf09427ac132b913091cb3d8c1e733a Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Fri, 24 Apr 2020 15:18:54 -0400 Subject: [PATCH] [dev.link] cmd/link: fix minor error on error reporting Correctly propagate ... arguments. (Maybe vet should warn on it?) Reviewed-on: https://go-review.googlesource.com/c/go/+/230017 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot Reviewed-by: Than McIntosh Change-Id: Ife56dc2321847cdaf0caea3142c2c7dad8b5924d Reviewed-on: https://go-review.googlesource.com/c/go/+/230027 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot Reviewed-by: Cherry Zhang --- src/cmd/link/internal/ld/util.go | 2 +- src/cmd/link/internal/loader/loader.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/link/internal/ld/util.go b/src/cmd/link/internal/ld/util.go index b8c9ce28b0..2186503f0c 100644 --- a/src/cmd/link/internal/ld/util.go +++ b/src/cmd/link/internal/ld/util.go @@ -74,7 +74,7 @@ func Errorf(s *sym.Symbol, format string, args ...interface{}) { // output file and return a non-zero error code. func (ctxt *Link) Errorf(s loader.Sym, format string, args ...interface{}) { if ctxt.loader != nil { - ctxt.loader.Errorf(s, format, args) + ctxt.loader.Errorf(s, format, args...) return } // Note: this is not expected to happen very often. diff --git a/src/cmd/link/internal/loader/loader.go b/src/cmd/link/internal/loader/loader.go index 375e5c32b6..5d62690f82 100644 --- a/src/cmd/link/internal/loader/loader.go +++ b/src/cmd/link/internal/loader/loader.go @@ -2825,7 +2825,7 @@ func (l *Loader) GetErrorReporter() *ErrorReporter { // Errorf method logs an error message. See ErrorReporter.Errorf for details. func (l *Loader) Errorf(s Sym, format string, args ...interface{}) { - l.errorReporter.Errorf(s, format, args) + l.errorReporter.Errorf(s, format, args...) } // For debugging. -- 2.50.0