From 20e362dae73b84e7b9dba9959444e5bc9d513ff1 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 11 May 2016 09:37:46 -0700 Subject: [PATCH] cmd/cgo: remove //extern for check functions in gccgo Go prologue The //extern comments are incorrect and cause undefined symbol errorswhen building cgo code with -compiler=gccgo. The code is already designed to use weak references, and that support relies on the cgo check functions being treated as local functions. Change-Id: Ib38a640cc4ce6eba74cfbf41ba7147ec88769ec0 Reviewed-on: https://go-review.googlesource.com/23014 Run-TryBot: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/cgo/out.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/cmd/cgo/out.go b/src/cmd/cgo/out.go index 5eab3a71b4..265a3bbe6f 100644 --- a/src/cmd/cgo/out.go +++ b/src/cmd/cgo/out.go @@ -1360,10 +1360,8 @@ func _cgoCheckResult(interface{}) ` const gccgoGoProlog = ` -//extern runtime.cgoCheckPointer func _cgoCheckPointer(interface{}, ...interface{}) interface{} -//extern runtime.cgoCheckResult func _cgoCheckResult(interface{}) ` -- 2.50.0