From 20e9b7f1b53d49fd66e0344b1d0d42d3cf5e47b6 Mon Sep 17 00:00:00 2001 From: Joel Sing Date: Fri, 3 Mar 2023 01:24:06 +1100 Subject: [PATCH] debug/dwarf: return ErrUnknownPC rather than nil on unknown PC Currently, on e == nil or e.Tag == 0, SeekPC returns with a nil error. Instead, indicate that the PC is unknown. Change-Id: I9594296034e2df872e399bd800b00cb565c413c9 Reviewed-on: https://go-review.googlesource.com/c/go/+/473695 Reviewed-by: Carlos Amedee TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor --- src/debug/dwarf/entry.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/debug/dwarf/entry.go b/src/debug/dwarf/entry.go index 5bb4297b48..f1215d2b01 100644 --- a/src/debug/dwarf/entry.go +++ b/src/debug/dwarf/entry.go @@ -975,9 +975,12 @@ func (r *Reader) SeekPC(pc uint64) (*Entry, error) { u := &r.d.unit[unit] r.b = makeBuf(r.d, u, "info", u.off, u.data) e, err := r.Next() - if err != nil || e == nil || e.Tag == 0 { + if err != nil { return nil, err } + if e == nil || e.Tag == 0 { + return nil, ErrUnknownPC + } ranges, err := r.d.Ranges(e) if err != nil { return nil, err -- 2.48.1