From 26338a7f691b45017168b6523c95d4578a2cfd4d Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Thu, 22 May 2025 20:57:33 +0700 Subject: [PATCH] cmd/compile: use better fatal message for staticValue1 So the position of the wrong assignment statement will be reported, instead of using incorrect base.Pos one. Notice while fixing issue #73823. Change-Id: I53f240bf99d11b5f5082ee4ca0903d9f099881b6 Reviewed-on: https://go-review.googlesource.com/c/go/+/675495 LUCI-TryBot-Result: Go LUCI Auto-Submit: Cuong Manh Le Reviewed-by: Keith Randall Reviewed-by: Mateusz Poliwczak Reviewed-by: Keith Randall Reviewed-by: David Chase --- src/cmd/compile/internal/ir/expr.go | 4 ++-- src/cmd/compile/internal/ir/reassignment.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cmd/compile/internal/ir/expr.go b/src/cmd/compile/internal/ir/expr.go index 702adfdd84..98b353147f 100644 --- a/src/cmd/compile/internal/ir/expr.go +++ b/src/cmd/compile/internal/ir/expr.go @@ -912,12 +912,12 @@ FindRHS: break FindRHS } } - base.Fatalf("%v missing from LHS of %v", n, defn) + base.FatalfAt(defn.Pos(), "%v missing from LHS of %v", n, defn) default: return nil } if rhs == nil { - base.Fatalf("RHS is nil: %v", defn) + base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn) } if Reassigned(n) { diff --git a/src/cmd/compile/internal/ir/reassignment.go b/src/cmd/compile/internal/ir/reassignment.go index ff54f708c2..ba14d078a2 100644 --- a/src/cmd/compile/internal/ir/reassignment.go +++ b/src/cmd/compile/internal/ir/reassignment.go @@ -178,12 +178,12 @@ FindRHS: break FindRHS } } - base.Fatalf("%v missing from LHS of %v", n, defn) + base.FatalfAt(defn.Pos(), "%v missing from LHS of %v", n, defn) default: return nil } if rhs == nil { - base.Fatalf("RHS is nil: %v", defn) + base.FatalfAt(defn.Pos(), "RHS is nil: %v", defn) } if _, ok := ro.singleDef[n]; !ok { -- 2.51.0