From 26d6d077859c8d778ec51036fb8e9b4676e181b6 Mon Sep 17 00:00:00 2001 From: Cherry Zhang Date: Sat, 25 Apr 2020 14:25:18 -0400 Subject: [PATCH] [dev.link] cmd/link: remove symbol movement workaround in dodata It is supposed to work around symbol movement in machosymorder. But machosymorder doesn't actually move symbols around. Change-Id: Ibdc2ad41aaa8cd49e865088aa1ddb7ab399736cd Reviewed-on: https://go-review.googlesource.com/c/go/+/230279 Run-TryBot: Cherry Zhang TryBot-Result: Gobot Gobot Reviewed-by: Than McIntosh Reviewed-by: Jeremy Faller --- src/cmd/link/internal/ld/data.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/cmd/link/internal/ld/data.go b/src/cmd/link/internal/ld/data.go index 4b3bc2ce02..5ab7661d60 100644 --- a/src/cmd/link/internal/ld/data.go +++ b/src/cmd/link/internal/ld/data.go @@ -1893,18 +1893,6 @@ func (state *dodataState) allocateDwarfSections2(ctxt *Link) { } func (state *dodataState) dodataSect2(ctxt *Link, symn sym.SymKind, syms []loader.Sym) (result []loader.Sym, maxAlign int32) { - if ctxt.HeadType == objabi.Hdarwin { - // Some symbols may no longer belong in syms - // due to movement in machosymorder. - newSyms := make([]loader.Sym, 0, len(syms)) - for _, s := range syms { - if state.symType(s) == symn { - newSyms = append(newSyms, s) - } - } - syms = newSyms - } - var head, tail loader.Sym ldr := ctxt.loader for _, s := range syms { -- 2.50.0