From 27a10f7da791602cc6d059d3164052aa397d6ef3 Mon Sep 17 00:00:00 2001 From: David Crawshaw Date: Thu, 4 May 2017 17:36:20 -0400 Subject: [PATCH] cmd/link: stop passing unused read_only_relocs The external darwin linker has been printing: ld: warning: -read_only_relocs cannot be used with x86_64 for a long time. Now that it is printed by CL 33301, we may as well get rid of it. Fixes #20246 Change-Id: I1147cf1ff197fdfda228a1349f13627bcf9fc72f Reviewed-on: https://go-review.googlesource.com/42730 Run-TryBot: David Crawshaw TryBot-Result: Gobot Gobot Reviewed-by: Todd Neal Reviewed-by: Brad Fitzpatrick --- src/cmd/link/internal/ld/lib.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index b69e3a6018..43c7d73f9f 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -1075,7 +1075,10 @@ func (l *Link) hostlink() { argv = append(argv, "-pie") case BuildmodeCShared: if Headtype == objabi.Hdarwin { - argv = append(argv, "-dynamiclib", "-Wl,-read_only_relocs,suppress") + argv = append(argv, "-dynamiclib") + if SysArch.Family != sys.AMD64 { + argv = append(argv, "-Wl,-read_only_relocs,suppress") + } } else { // ELF. argv = append(argv, "-Wl,-Bsymbolic") -- 2.50.0