From 2869d55366a55d6a29a166523ac2383d0b2291df Mon Sep 17 00:00:00 2001 From: Damien Neil Date: Thu, 6 Mar 2025 17:33:27 -0800 Subject: [PATCH] net/http: test intended behavior in TestClientInsecureTransport This test wasn't testing the HTTP/2 case, because it didn't set NextProtos in the tls.Config. Set "Connection: close" on requests to make sure each request gets a new connection. Change-Id: I1ef470e7433a602ce88da7bd7eeec502687ea857 Reviewed-on: https://go-review.googlesource.com/c/go/+/655676 LUCI-TryBot-Result: Go LUCI Reviewed-by: Sean Liao Auto-Submit: Damien Neil Reviewed-by: Michael Pratt --- src/net/http/client_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index 1ce9539528..ec5ac7ffeb 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -834,8 +834,11 @@ func testClientInsecureTransport(t *testing.T, mode testMode) { for _, insecure := range []bool{true, false} { c.Transport.(*Transport).TLSClientConfig = &tls.Config{ InsecureSkipVerify: insecure, + NextProtos: cst.tr.TLSClientConfig.NextProtos, } - res, err := c.Get(ts.URL) + req, _ := NewRequest("GET", ts.URL, nil) + req.Header.Set("Connection", "close") // don't reuse this connection + res, err := c.Do(req) if (err == nil) != insecure { t.Errorf("insecure=%v: got unexpected err=%v", insecure, err) } -- 2.51.0