From 29cea6583ead4fa5b12a333e6a9dabe3f8a52fdd Mon Sep 17 00:00:00 2001 From: Wingrez <31106425+wingrez@users.noreply.github.com> Date: Sun, 21 Jan 2024 09:26:40 +0000 Subject: [PATCH] cmd/compile/internal/ssa: fix typo in sccp Change-Id: I7f522a4e1b0c50a469ce948249342d6e7cf7777c GitHub-Last-Rev: f89d7ee576814c6ebde823b68a0b64bba8c2ad8f GitHub-Pull-Request: golang/go#65188 Reviewed-on: https://go-review.googlesource.com/c/go/+/557255 Reviewed-by: Keith Randall Reviewed-by: Cherry Mui Reviewed-by: Keith Randall Auto-Submit: Keith Randall LUCI-TryBot-Result: Go LUCI --- src/cmd/compile/internal/ssa/sccp.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cmd/compile/internal/ssa/sccp.go b/src/cmd/compile/internal/ssa/sccp.go index 77a6f50961..ecc0f94e5b 100644 --- a/src/cmd/compile/internal/ssa/sccp.go +++ b/src/cmd/compile/internal/ssa/sccp.go @@ -80,7 +80,7 @@ func sccp(f *Func) { // build it early since we rely heavily on the def-use chain later t.buildDefUses() - // pick up either an edge or SSA value from worklilst, process it + // pick up either an edge or SSA value from worklist, process it for { if len(t.edges) > 0 { edge := t.edges[0] @@ -145,7 +145,7 @@ func equals(a, b lattice) bool { return true } -// possibleConst checks if Value can be fold to const. For those Values that can +// possibleConst checks if Value can be folded to const. For those Values that can // never become constants(e.g. StaticCall), we don't make futile efforts. func possibleConst(val *Value) bool { if isConst(val) { @@ -343,7 +343,7 @@ func computeLattice(f *Func, val *Value, args ...*Value) lattice { // However, this would create a huge switch for all opcodes that can be // evaluated during compile time. Moreover, some operations can be evaluated // only if its arguments satisfy additional conditions(e.g. divide by zero). - // It's fragile and error prone. We did a trick by reusing the existing rules + // It's fragile and error-prone. We did a trick by reusing the existing rules // in generic rules for compile-time evaluation. But generic rules rewrite // original value, this behavior is undesired, because the lattice of values // may change multiple times, once it was rewritten, we lose the opportunity -- 2.48.1