From 2c7043c273a04dc3ca081321484c8a30d4c2c23b Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Fri, 9 Jun 2017 00:02:53 +0000 Subject: [PATCH] net: don't run TestDialListenerAddr in short mode on non-builders It listens on all addresses, which users might not want. Updates #18806 (follow-up to feedback from CL 45088) Change-Id: I51de2d3fc3cd88a61eb3c63018c47aea920c0549 Reviewed-on: https://go-review.googlesource.com/45157 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Mikio Hara --- src/net/dial_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/net/dial_test.go b/src/net/dial_test.go index 59a016a0c5..a892bf1e14 100644 --- a/src/net/dial_test.go +++ b/src/net/dial_test.go @@ -893,6 +893,9 @@ func TestCancelAfterDial(t *testing.T) { // if the machine has halfway configured IPv6 such that it can bind on // "::" not connect back to that same address. func TestDialListenerAddr(t *testing.T) { + if testenv.Builder() == "" { + testenv.MustHaveExternalNetwork(t) + } ln, err := Listen("tcp", ":0") if err != nil { t.Fatal(err) -- 2.50.0