From 2c80de74d57de74cc50ba7195392cada4e9c3ea2 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Sat, 7 Nov 2020 12:03:36 +0700 Subject: [PATCH] cmd/link: fix invalid usage of reflect.SliceHeader Caught by "go vet" built with golang.org/cl/248192. Change-Id: I446083533dd82ecef8db591beb7bd3d70b040d4a Reviewed-on: https://go-review.googlesource.com/c/go/+/268099 Trust: Cuong Manh Le Run-TryBot: Cuong Manh Le TryBot-Result: Go Bot Reviewed-by: Ian Lance Taylor Reviewed-by: Cherry Zhang --- src/cmd/link/internal/ld/outbuf_windows.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cmd/link/internal/ld/outbuf_windows.go b/src/cmd/link/internal/ld/outbuf_windows.go index 60dc1ab92d..915c72bef3 100644 --- a/src/cmd/link/internal/ld/outbuf_windows.go +++ b/src/cmd/link/internal/ld/outbuf_windows.go @@ -35,7 +35,10 @@ func (out *OutBuf) Mmap(filesize uint64) error { if err != nil { return err } - *(*reflect.SliceHeader)(unsafe.Pointer(&out.buf)) = reflect.SliceHeader{Data: ptr, Len: int(filesize), Cap: int(filesize)} + bufHdr := (*reflect.SliceHeader)(unsafe.Pointer(&out.buf)) + bufHdr.Data = ptr + bufHdr.Len = int(filesize) + bufHdr.Cap = int(filesize) // copy heap to new mapping if uint64(oldlen+len(out.heap)) > filesize { -- 2.50.0