From 2cf632cd57fac7edacb9ad4621ce0234b81d0bc3 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Thu, 30 Jun 2022 19:38:10 -0700 Subject: [PATCH] [dev.unified] cmd/compile/internal/reflectdata: prefer ITabAddrAt in ConvIfaceTypeWord We already have an explicit `pos` parameter, so we should use ITabAddrAt instead of ITabAddr (which uses `base.Pos` instead). Change-Id: I7c8c5ae93d0ae7a6467cc972575cb547981576f0 Reviewed-on: https://go-review.googlesource.com/c/go/+/415578 Run-TryBot: Matthew Dempsky Reviewed-by: David Chase TryBot-Result: Gopher Robot --- src/cmd/compile/internal/reflectdata/helpers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/compile/internal/reflectdata/helpers.go b/src/cmd/compile/internal/reflectdata/helpers.go index 03d1ae3dc2..81bb18788f 100644 --- a/src/cmd/compile/internal/reflectdata/helpers.go +++ b/src/cmd/compile/internal/reflectdata/helpers.go @@ -113,7 +113,7 @@ func ConvIfaceTypeWord(pos src.XPos, n *ir.ConvExpr) ir.Node { return concreteRType(pos, src) // direct eface construction } if !src.IsInterface() { - return ITabAddr(src, dst) // direct iface construction + return ITabAddrAt(pos, src, dst) // direct iface construction } return TypePtrAt(pos, dst) // convI2I } -- 2.50.0