From 2d6ee6e89a4b30c7528d2977df4e1aa86651e4e4 Mon Sep 17 00:00:00 2001 From: Baokun Lee Date: Fri, 2 Aug 2019 00:31:57 +0800 Subject: [PATCH] os: enable the close-on-exec flag for openFdAt There's a race here with fork/exec, enable the close-on-exec flag for the new file descriptor. Fixes #33405 Change-Id: If95bae97a52b7026a930bb3427e47bae3b0032ac Reviewed-on: https://go-review.googlesource.com/c/go/+/188537 Run-TryBot: Baokun Lee TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- src/os/removeall_at.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/os/removeall_at.go b/src/os/removeall_at.go index 3098b93368..bc632f5a75 100644 --- a/src/os/removeall_at.go +++ b/src/os/removeall_at.go @@ -173,7 +173,7 @@ func openFdAt(dirfd int, name string) (*File, error) { var r int for { var e error - r, e = unix.Openat(dirfd, name, O_RDONLY, 0) + r, e = unix.Openat(dirfd, name, O_RDONLY|syscall.O_CLOEXEC, 0) if e == nil { break } -- 2.48.1