From 2da9659158f87c1d3c0ccb7ff8aec7c1bafe570b Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Tue, 2 Apr 2019 15:05:33 -0700 Subject: [PATCH] misc/cgo/testcarchive: skip TestSignalForwardingExternal on darwin/amd64 On darwin/amd64 the runtime method sigctxt.fixsigcode changes SIGSEGV signals so that they are never marked SI_USER. CL 169120 changed the signal handler to call fixsigcode even when the signal is delivered to a non-Go thread. This breaks TestSignalForwardingExternal, so skip it. Change-Id: I6740fb5a8f4f854ca69793537a983a696da3b495 Reviewed-on: https://go-review.googlesource.com/c/go/+/170446 Run-TryBot: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- misc/cgo/testcarchive/carchive_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/misc/cgo/testcarchive/carchive_test.go b/misc/cgo/testcarchive/carchive_test.go index b7f04356a9..5fbe9caafb 100644 --- a/misc/cgo/testcarchive/carchive_test.go +++ b/misc/cgo/testcarchive/carchive_test.go @@ -325,6 +325,8 @@ func TestSignalForwarding(t *testing.T) { func TestSignalForwardingExternal(t *testing.T) { if GOOS == "freebsd" || GOOS == "aix" { t.Skipf("skipping on %s/%s; signal always goes to the Go runtime", GOOS, GOARCH) + } else if GOOS == "darwin" && GOARCH == "amd64" { + t.Skipf("skipping on %s/%s: runtime does not permit SI_USER SIGSEGV", GOOS, GOARCH) } checkSignalForwardingTest(t) -- 2.50.0