From 2f40dc79e5febf2c27303285ef853a5dd064f777 Mon Sep 17 00:00:00 2001 From: Hana Kim Date: Thu, 19 Oct 2017 17:47:07 -0400 Subject: [PATCH] cmd/trace: fix a javascript bug in handling import error When traceviewer encounters a failure of json trace import due to data error, onImportFail tried to access an error variable which was not yet defined. Change-Id: I431be03f179aafacaf1fd3c62a6337e8b5bd18fb Reviewed-on: https://go-review.googlesource.com/71970 Reviewed-by: Austin Clements --- src/cmd/trace/trace.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cmd/trace/trace.go b/src/cmd/trace/trace.go index 784e413335..7178287751 100644 --- a/src/cmd/trace/trace.go +++ b/src/cmd/trace/trace.go @@ -114,7 +114,7 @@ var templTrace = ` viewer.viewTitle = "trace"; } - function onImportFail() { + function onImportFail(err) { var overlay = new tr.ui.b.Overlay(); overlay.textContent = tr.b.normalizeException(err).message; overlay.title = 'Import error'; -- 2.48.1