From 2fc21b50e4c19d60ad7c91bcfe6488e0f13abde3 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 24 Aug 2022 10:10:12 -0400 Subject: [PATCH] cmd/go: skip link_syso tests in short mode These tests invoke the system C compiler and linker. Skipping them saves a little over half a second of time in short mode. Updates #54423. Change-Id: I3e8aa7b53c0c91f7d1e001ec2cd5f7b4954de52d Reviewed-on: https://go-review.googlesource.com/c/go/+/425206 TryBot-Result: Gopher Robot Reviewed-by: Than McIntosh Auto-Submit: Bryan Mills Run-TryBot: Bryan Mills --- src/cmd/go/testdata/script/link_syso_deps.txt | 3 ++- src/cmd/go/testdata/script/link_syso_issue33139.txt | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cmd/go/testdata/script/link_syso_deps.txt b/src/cmd/go/testdata/script/link_syso_deps.txt index 7b458b0826..c713304d9f 100644 --- a/src/cmd/go/testdata/script/link_syso_deps.txt +++ b/src/cmd/go/testdata/script/link_syso_deps.txt @@ -1,7 +1,8 @@ # Test that syso in deps is available to cgo. -[!gc] skip +[!gc] skip 'requires syso support' [!cgo] skip +[short] skip 'invokes system C compiler' # External linking is not supported on linux/ppc64. # See: https://github.com/golang/go/issues/8912 diff --git a/src/cmd/go/testdata/script/link_syso_issue33139.txt b/src/cmd/go/testdata/script/link_syso_issue33139.txt index 8a8cb4aa8c..36746e6499 100644 --- a/src/cmd/go/testdata/script/link_syso_issue33139.txt +++ b/src/cmd/go/testdata/script/link_syso_issue33139.txt @@ -1,8 +1,10 @@ # Test that we can use the external linker with a host syso file that is # embedded in a package, that is referenced by a Go assembly function. # See issue 33139. + [!gc] skip [!cgo] skip +[short] skip 'invokes system C compiler' # External linking is not supported on linux/ppc64. # See: https://github.com/golang/go/issues/8912 -- 2.50.0