From 3123df3464ff8df1d15452b51360e1b7f05dbcd3 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 1 Mar 2017 05:42:32 +0000 Subject: [PATCH] net/http: fix flaky TestClientRedirect308NoLocation This was a t.Parallel test but it was using the global DefaultTransport via the global Get func. Use a private Transport that won't have its CloseIdleConnections etc methods called by other tests. (I hit this flake myself while testing a different change.) Change-Id: If0665e3e8580ee198f8e5f3079bfaea55f036eca Reviewed-on: https://go-review.googlesource.com/37624 Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot Reviewed-by: Josh Bleecher Snyder --- src/net/http/client_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/net/http/client_test.go b/src/net/http/client_test.go index 4f674dd8d6..105b310c6a 100644 --- a/src/net/http/client_test.go +++ b/src/net/http/client_test.go @@ -555,7 +555,8 @@ func TestClientRedirect308NoLocation(t *testing.T) { w.WriteHeader(308) })) defer ts.Close() - res, err := Get(ts.URL) + c := &Client{Transport: &Transport{DisableKeepAlives: true}} + res, err := c.Get(ts.URL) if err != nil { t.Fatal(err) } -- 2.48.1