From 32b9e568d8c28e63a8f1d93e69b57794350de159 Mon Sep 17 00:00:00 2001 From: Stefan Baebler Date: Wed, 7 Aug 2019 14:16:59 +0000 Subject: [PATCH] net/url: fail TestParseErrors test when getting an unwanted error The TestParseErrors test function was not strict with unwanted errors received from url.Parse(). It was not failing in such cases, now it does. Change-Id: I18a26a68c1136f5c762989a76e04b47e33dd35f1 GitHub-Last-Rev: c33f9842f7908f27012859e25caa79388cc2785a GitHub-Pull-Request: golang/go#32954 Reviewed-on: https://go-review.googlesource.com/c/go/+/185080 Reviewed-by: Emmanuel Odeke Run-TryBot: Emmanuel Odeke TryBot-Result: Gobot Gobot --- src/net/url/url_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/url/url_test.go b/src/net/url/url_test.go index e83c86c424..b86956906d 100644 --- a/src/net/url/url_test.go +++ b/src/net/url/url_test.go @@ -1456,7 +1456,7 @@ func TestParseErrors(t *testing.T) { continue } if err != nil { - t.Logf("Parse(%q) = %v; want no error", tt.in, err) + t.Errorf("Parse(%q) = %v; want no error", tt.in, err) } } } -- 2.50.0