From 3457359b90c1b4ef0c9143d2d2e9575b3e72cf4b Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Mon, 13 Jan 2020 11:24:06 -0500 Subject: [PATCH] cmd/go: convert TestRelativeGOBINFail to script framework Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: I1cb3e2e28700b05b08933f4e24cd996268c1f163 Reviewed-on: https://go-review.googlesource.com/c/go/+/214428 Reviewed-by: Jay Conrod --- src/cmd/go/go_test.go | 10 ---------- .../go/testdata/script/install_relative_gobin_fail.txt | 8 ++++++++ 2 files changed, 8 insertions(+), 10 deletions(-) create mode 100644 src/cmd/go/testdata/script/install_relative_gobin_fail.txt diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go index afedcb816d..9da94360f9 100644 --- a/src/cmd/go/go_test.go +++ b/src/cmd/go/go_test.go @@ -1138,16 +1138,6 @@ func TestMSanAndRaceRequireCgo(t *testing.T) { } } -func TestRelativeGOBINFail(t *testing.T) { - tg := testgo(t) - defer tg.cleanup() - tg.tempFile("triv.go", `package main; func main() {}`) - tg.setenv("GOBIN", ".") - tg.cd(tg.path(".")) - tg.runFail("install") - tg.grepStderr("cannot install, GOBIN must be an absolute path", "go install must fail if $GOBIN is a relative path") -} - func TestPackageMainTestCompilerFlags(t *testing.T) { tg := testgo(t) defer tg.cleanup() diff --git a/src/cmd/go/testdata/script/install_relative_gobin_fail.txt b/src/cmd/go/testdata/script/install_relative_gobin_fail.txt new file mode 100644 index 0000000000..e1e9ec7bdf --- /dev/null +++ b/src/cmd/go/testdata/script/install_relative_gobin_fail.txt @@ -0,0 +1,8 @@ +env GOBIN=. +! go install +stderr 'cannot install, GOBIN must be an absolute path' + +-- triv.go -- +package main + +func main() {} \ No newline at end of file -- 2.50.0